llamactl/pkg/manager/manager_test.go

package manager_test

import (
	"fmt"
	"llamactl/pkg/backends"
	"llamactl/pkg/config"
	"llamactl/pkg/instance"
	"llamactl/pkg/manager"
	"os"
	"path/filepath"
	"sync"
	"testing"
)

func TestManager_PersistsAndLoadsInstances(t *testing.T) {
	tempDir := t.TempDir()
	cfg := createPersistenceConfig(tempDir)
	backendConfig := createBackendConfig()

	// Create instance and check file was created
	manager1 := manager.New(backendConfig, cfg, map[string]config.NodeConfig{}, "main")
	options := &instance.Options{
		BackendOptions: backends.Options{
			BackendType: backends.BackendTypeLlamaCpp,
			LlamaServerOptions: &backends.LlamaServerOptions{
				Model: "/path/to/model.gguf",
				Port:  8080,
			},
		},
	}

	_, err := manager1.CreateInstance("test-instance", options)
	if err != nil {
		t.Fatalf("CreateInstance failed: %v", err)
	}

	expectedPath := filepath.Join(tempDir, "test-instance.json")
	if _, err := os.Stat(expectedPath); os.IsNotExist(err) {
		t.Errorf("Expected persistence file %s to exist", expectedPath)
	}

	// Load instances from disk
	manager2 := manager.New(backendConfig, cfg, map[string]config.NodeConfig{}, "main")
	instances, err := manager2.ListInstances()
	if err != nil {
		t.Fatalf("ListInstances failed: %v", err)
	}
	if len(instances) != 1 {
		t.Fatalf("Expected 1 loaded instance, got %d", len(instances))
	}
	if instances[0].Name != "test-instance" {
		t.Errorf("Expected loaded instance name 'test-instance', got %q", instances[0].Name)
	}
}

func TestDeleteInstance_RemovesPersistenceFile(t *testing.T) {
	tempDir := t.TempDir()
	cfg := createPersistenceConfig(tempDir)
	backendConfig := createBackendConfig()

	mgr := manager.New(backendConfig, cfg, map[string]config.NodeConfig{}, "main")
	options := &instance.Options{
		BackendOptions: backends.Options{
			BackendType: backends.BackendTypeLlamaCpp,
			LlamaServerOptions: &backends.LlamaServerOptions{
				Model: "/path/to/model.gguf",
				Port:  8080,
			},
		},
	}

	_, err := mgr.CreateInstance("test-instance", options)
	if err != nil {
		t.Fatalf("CreateInstance failed: %v", err)
	}

	expectedPath := filepath.Join(tempDir, "test-instance.json")

	err = mgr.DeleteInstance("test-instance")
	if err != nil {
		t.Fatalf("DeleteInstance failed: %v", err)
	}

	if _, err := os.Stat(expectedPath); !os.IsNotExist(err) {
		t.Error("Expected persistence file to be deleted")
	}
}

func TestConcurrentAccess(t *testing.T) {
	mgr := createTestManager()
	defer mgr.Shutdown()

	// Test concurrent operations
	var wg sync.WaitGroup
	errChan := make(chan error, 10)

	// Concurrent instance creation
	for i := range 5 {
		wg.Add(1)
		go func(index int) {
			defer wg.Done()
			options := &instance.Options{
				BackendOptions: backends.Options{
					BackendType: backends.BackendTypeLlamaCpp,
					LlamaServerOptions: &backends.LlamaServerOptions{
						Model: "/path/to/model.gguf",
					},
				},
			}
			instanceName := fmt.Sprintf("concurrent-test-%d", index)
			if _, err := mgr.CreateInstance(instanceName, options); err != nil {
				errChan <- err
			}
		}(i)
	}

	// Concurrent list operations
	for i := 0; i < 3; i++ {
		wg.Add(1)
		go func() {
			defer wg.Done()
			if _, err := mgr.ListInstances(); err != nil {
				errChan <- err
			}
		}()
	}

	wg.Wait()
	close(errChan)

	// Check for any errors during concurrent access
	for err := range errChan {
		t.Errorf("Concurrent access error: %v", err)
	}
}

// TestCreateInstance_RejectsPathTraversal tests that instance names with path traversal attempts are rejected
func TestCreateInstance_RejectsPathTraversal(t *testing.T) {
	tempDir := t.TempDir()
	cfg := createPersistenceConfig(tempDir)
	backendConfig := createBackendConfig()
	mgr := manager.New(backendConfig, cfg, map[string]config.NodeConfig{}, "main")

	options := &instance.Options{
		BackendOptions: backends.Options{
			BackendType: backends.BackendTypeLlamaCpp,
			LlamaServerOptions: &backends.LlamaServerOptions{
				Model: "/path/to/model.gguf",
				Port:  8080,
			},
		},
	}

	// Test cases for malicious instance names
	maliciousNames := []string{
		"../../etc/passwd",      // Classic path traversal
		"../../../etc/shadow",   // Multiple parent directory references
		"/etc/passwd",           // Absolute path
		"foo/../bar",            // Parent reference in middle
		".../.../",              // Variation with multiple dots
		".hidden",               // Hidden file
		"foo/bar",               // Forward slash
		"foo\\bar",              // Backslash (Windows-style)
		"test..instance",        // Double dots not at path boundary (should fail)
		"normal-name/../escape", // Normal-looking name with traversal
	}

	for _, name := range maliciousNames {
		t.Run(name, func(t *testing.T) {
			_, err := mgr.CreateInstance(name, options)
			if err == nil {
				t.Errorf("Expected error when creating instance with malicious name %q, but got none", name)
			}
		})
	}
}

// TestCreateInstance_AcceptsValidNames tests that valid instance names are accepted
func TestCreateInstance_AcceptsValidNames(t *testing.T) {
	tempDir := t.TempDir()
	cfg := createPersistenceConfig(tempDir)
	backendConfig := createBackendConfig()
	mgr := manager.New(backendConfig, cfg, map[string]config.NodeConfig{}, "main")
	defer mgr.Shutdown()

	options := &instance.Options{
		BackendOptions: backends.Options{
			BackendType: backends.BackendTypeLlamaCpp,
			LlamaServerOptions: &backends.LlamaServerOptions{
				Model: "/path/to/model.gguf",
			},
		},
	}

	// Valid instance names
	validNames := []string{
		"test-instance",
		"my_instance",
		"instance123",
		"test-name-with-dashes",
		"name_with_underscores",
	}

	for _, name := range validNames {
		t.Run(name, func(t *testing.T) {
			_, err := mgr.CreateInstance(name, options)
			if err != nil {
				t.Errorf("Expected instance with valid name %q to be created, but got error: %v", name, err)
			}
			// Clean up
			mgr.DeleteInstance(name)
		})
	}
}

// Helper functions for test configuration
func createBackendConfig() config.BackendConfig {
	// Use 'sleep' as a test command instead of 'llama-server'
	// This allows tests to run in CI environments without requiring actual LLM binaries
	// The sleep command will be invoked with model paths and other args, which it ignores
	return config.BackendConfig{
		LlamaCpp: config.BackendSettings{
			Command: "sleep",
		},
		MLX: config.BackendSettings{
			Command: "sleep",
		},
	}
}

func createPersistenceConfig(dir string) config.InstancesConfig {
	return config.InstancesConfig{
		PortRange:            [2]int{8000, 9000},
		InstancesDir:         dir,
		MaxInstances:         10,
		TimeoutCheckInterval: 5,
	}
}

func createTestManager() manager.InstanceManager {
	cfg := config.InstancesConfig{
		PortRange:            [2]int{8000, 9000},
		LogsDir:              "/tmp/test",
		MaxInstances:         10,
		MaxRunningInstances:  10,
		DefaultAutoRestart:   true,
		DefaultMaxRestarts:   3,
		DefaultRestartDelay:  5,
		TimeoutCheckInterval: 5,
	}
	return manager.New(createBackendConfig(), cfg, map[string]config.NodeConfig{}, "main")
}