Refactor instance locking mechanism to use per-instance locks for concurrency

This commit is contained in:
2025-10-20 22:59:31 +02:00
parent d923732aba
commit a2d4622486
2 changed files with 40 additions and 17 deletions

View File

@@ -40,8 +40,9 @@ type instanceManager struct {
localNodeName string // Name of the local node
// Synchronization
operationMu sync.Mutex // Protects start/stop/update/delete/restart operations
shutdownOnce sync.Once
operationMu sync.Mutex // DEPRECATED: Use instanceLocks for per-instance operations
instanceLocks sync.Map // map[string]*sync.Mutex - per-instance locks for concurrent operations
shutdownOnce sync.Once
}
// New creates a new instance of InstanceManager.
@@ -287,3 +288,20 @@ func (im *instanceManager) getNodeForInstance(inst *instance.Instance) *config.N
return nil
}
// lockInstance returns the lock for a specific instance, creating one if needed.
// This allows concurrent operations on different instances while preventing
// concurrent operations on the same instance.
func (im *instanceManager) lockInstance(name string) *sync.Mutex {
lock, _ := im.instanceLocks.LoadOrStore(name, &sync.Mutex{})
return lock.(*sync.Mutex)
}
// unlockAndCleanup unlocks the instance lock and removes it from the map.
// This should only be called when deleting an instance to prevent memory leaks.
func (im *instanceManager) unlockAndCleanup(name string) {
if lock, ok := im.instanceLocks.Load(name); ok {
lock.(*sync.Mutex).Unlock()
im.instanceLocks.Delete(name)
}
}