Mathis/llamactl
1
0
Fork 0
mirror of https://github.com/lordmathis/llamactl.git synced 2025-11-05 16:44:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove GetBackendSettings method from config

Browse Source
This commit is contained in:
Matúš Námešný
2025-10-19 18:32:05 +02:00
parent 3500971f03
commit 867380a06d
2 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/config/config.go
View File

@@ -601,17 +601,3 @@ func getDefaultConfigLocations() []string {
return locations return locations
} }
// GetBackendSettings resolves backend settings
func (bc *BackendConfig) GetBackendSettings(backendType string) BackendSettings {
switch backendType {
case "llama-cpp":
return bc.LlamaCpp
case "vllm":
return bc.VLLM
case "mlx":
return bc.MLX
default:
return BackendSettings{}
}
}

28
pkg/config/config_test.go
View File

@@ -7,6 +7,20 @@ import (
"testing" "testing"
) )
// GetBackendSettings resolves backend settings
func getBackendSettings(bc *config.BackendConfig, backendType string) config.BackendSettings {
switch backendType {
case "llama-cpp":
return bc.LlamaCpp
case "vllm":
return bc.VLLM
case "mlx":
return bc.MLX
default:
return config.BackendSettings{}
}
}
func TestLoadConfig_Defaults(t *testing.T) { func TestLoadConfig_Defaults(t *testing.T) {
// Test loading config when no file exists and no env vars set // Test loading config when no file exists and no env vars set
cfg, err := config.LoadConfig("nonexistent-file.yaml") cfg, err := config.LoadConfig("nonexistent-file.yaml")
@@ -372,7 +386,7 @@ func TestGetBackendSettings_NewStructuredConfig(t *testing.T) {
} }
// Test llama-cpp with Docker // Test llama-cpp with Docker
settings := bc.GetBackendSettings("llama-cpp") settings := getBackendSettings(bc, "llama-cpp")
if settings.Command != "custom-llama" { if settings.Command != "custom-llama" {
t.Errorf("Expected command 'custom-llama', got %q", settings.Command) t.Errorf("Expected command 'custom-llama', got %q", settings.Command)
} }
@@ -387,7 +401,7 @@ func TestGetBackendSettings_NewStructuredConfig(t *testing.T) {
} }
// Test vLLM without Docker // Test vLLM without Docker
settings = bc.GetBackendSettings("vllm") settings = getBackendSettings(bc, "vllm")
if settings.Command != "custom-vllm" { if settings.Command != "custom-vllm" {
t.Errorf("Expected command 'custom-vllm', got %q", settings.Command) t.Errorf("Expected command 'custom-vllm', got %q", settings.Command)
} }
@@ -399,7 +413,7 @@ func TestGetBackendSettings_NewStructuredConfig(t *testing.T) {
} }
// Test MLX // Test MLX
settings = bc.GetBackendSettings("mlx") settings = getBackendSettings(bc, "mlx")
if settings.Command != "custom-mlx" { if settings.Command != "custom-mlx" {
t.Errorf("Expected command 'custom-mlx', got %q", settings.Command) t.Errorf("Expected command 'custom-mlx', got %q", settings.Command)
} }
@@ -409,19 +423,19 @@ func TestGetBackendSettings_EmptyConfig(t *testing.T) {
bc := &config.BackendConfig{} bc := &config.BackendConfig{}
// Test empty llama-cpp // Test empty llama-cpp
settings := bc.GetBackendSettings("llama-cpp") settings := getBackendSettings(bc, "llama-cpp")
if settings.Command != "" { if settings.Command != "" {
t.Errorf("Expected empty command, got %q", settings.Command) t.Errorf("Expected empty command, got %q", settings.Command)
} }
// Test empty vLLM // Test empty vLLM
settings = bc.GetBackendSettings("vllm") settings = getBackendSettings(bc, "vllm")
if settings.Command != "" { if settings.Command != "" {
t.Errorf("Expected empty command, got %q", settings.Command) t.Errorf("Expected empty command, got %q", settings.Command)
} }
// Test empty MLX // Test empty MLX
settings = bc.GetBackendSettings("mlx") settings = getBackendSettings(bc, "mlx")
if settings.Command != "" { if settings.Command != "" {
t.Errorf("Expected empty command, got %q", settings.Command) t.Errorf("Expected empty command, got %q", settings.Command)
} }
@@ -505,7 +519,7 @@ func TestGetBackendSettings_InvalidBackendType(t *testing.T) {
} }
// Test invalid backend type returns empty settings // Test invalid backend type returns empty settings
settings := bc.GetBackendSettings("invalid-backend") settings := getBackendSettings(bc, "invalid-backend")
if settings.Command != "" { if settings.Command != "" {
t.Errorf("Expected empty command for invalid backend, got %q", settings.Command) t.Errorf("Expected empty command for invalid backend, got %q", settings.Command)
} }