Mathis/llamactl
1
0
Fork 0
mirror of https://github.com/lordmathis/llamactl.git synced 2025-11-06 09:04:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make StartInstance and StopInstance idempotent

Browse Source
This commit is contained in:
Matúš Námešný
2025-10-21 18:49:49 +02:00
parent a2d4622486
commit 7c64ab9cc6
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/manager/operations.go
View File

@@ -383,8 +383,9 @@ func (im *instanceManager) StartInstance(name string) (*instance.Instance, error
lock.Lock() lock.Lock()
defer lock.Unlock() defer lock.Unlock()
// Idempotent: if already running, just return success
if inst.IsRunning() { if inst.IsRunning() {
return inst, fmt.Errorf("instance with name %s is already running", name) return inst, nil
} }
// Check max running instances limit for local instances only // Check max running instances limit for local instances only
@@ -446,8 +447,9 @@ func (im *instanceManager) StopInstance(name string) (*instance.Instance, error)
lock.Lock() lock.Lock()
defer lock.Unlock() defer lock.Unlock()
// Idempotent: if already stopped, just return success
if !inst.IsRunning() { if !inst.IsRunning() {
return inst, fmt.Errorf("instance with name %s is already stopped", name) return inst, nil
} }
if err := inst.Stop(); err != nil { if err := inst.Stop(); err != nil {