Mathis/llamactl
1
0
Fork 0
mirror of https://github.com/lordmathis/llamactl.git synced 2025-11-06 00:54:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add CanStartInstance method to check instance start conditions

Browse Source
This commit is contained in:
Matúš Námešný
2025-08-30 22:47:15 +02:00
parent a9f1c1a619
commit 68253be3e8
2 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/manager/manager.go
View File

@@ -21,6 +21,7 @@ type InstanceManager interface {
UpdateInstance(name string, options *instance.CreateInstanceOptions) (*instance.Process, error)
DeleteInstance(name string) error
StartInstance(name string) (*instance.Process, error)
CanStartInstance(inst *instance.Process) (bool, error)
StopInstance(name string) (*instance.Process, error)
RestartInstance(name string) (*instance.Process, error)
GetInstanceLogs(name string) (string, error)

26
pkg/manager/operations.go
View File

@@ -201,6 +201,32 @@ func (im *instanceManager) StartInstance(name string) (*instance.Process, error)
return instance, nil
}
// CanStartInstance checks if an instance can be started.
// An instance can be started if:
// 1. It is not already running, AND
// 2. Either:
// a) There is capacity (MaxRunningInstances is unlimited or not reached), OR
// b) The instance has on-demand start enabled AND LRU eviction is enabled
// (allowing older instances to be evicted to make room)
func (im *instanceManager) CanStartInstance(inst *instance.Process) (bool, error) {
im.mu.RLock()
defer im.mu.RUnlock()
if inst == nil {
return false, fmt.Errorf("instance is nil")
}
if inst.IsRunning() {
return false, fmt.Errorf("instance with name %s is already running", inst.Name)
}
allowMaxRunning := im.instancesConfig.MaxRunningInstances == -1 || len(im.runningInstances) < im.instancesConfig.MaxRunningInstances
allowOnDemand := inst.GetOptions() != nil && inst.GetOptions().OnDemandStart != nil && *inst.GetOptions().OnDemandStart
allowLRUEviction := im.instancesConfig.EnableLRUEviction
return allowMaxRunning || (allowOnDemand && allowLRUEviction), nil
}
// StopInstance stops a running instance and returns it.
func (im *instanceManager) StopInstance(name string) (*instance.Process, error) {
im.mu.RLock()