Refactor command argument building and parsing

This commit is contained in:
2025-09-19 19:59:46 +02:00
parent ec5485bd0e
commit 34a949d22e
7 changed files with 223 additions and 407 deletions

View File

@@ -313,10 +313,18 @@ func (o *LlamaServerOptions) UnmarshalJSON(data []byte) error {
return nil return nil
} }
// BuildCommandArgs converts InstanceOptions to command line arguments using the common builder // BuildCommandArgs converts InstanceOptions to command line arguments
func (o *LlamaServerOptions) BuildCommandArgs() []string { func (o *LlamaServerOptions) BuildCommandArgs() []string {
config := backends.ArgsBuilderConfig{ // Llama uses multiple flags for arrays by default (not comma-separated)
SliceHandling: backends.SliceAsMultipleFlags, // Llama uses multiple flags for arrays multipleFlags := map[string]bool{
"override-tensor": true,
"override-kv": true,
"lora": true,
"lora-scaled": true,
"control-vector": true,
"control-vector-scaled": true,
"dry-sequence-breaker": true,
"logit-bias": true,
} }
return backends.BuildCommandArgs(o, config) return backends.BuildCommandArgs(o, multipleFlags)
} }

View File

@@ -11,22 +11,21 @@ import (
// 3. Args only: "--model file.gguf --gpu-layers 32" // 3. Args only: "--model file.gguf --gpu-layers 32"
// 4. Multiline commands with backslashes // 4. Multiline commands with backslashes
func ParseLlamaCommand(command string) (*LlamaServerOptions, error) { func ParseLlamaCommand(command string) (*LlamaServerOptions, error) {
config := backends.CommandParserConfig{ executableNames := []string{"llama-server"}
ExecutableNames: []string{"llama-server"}, var subcommandNames []string // Llama has no subcommands
MultiValuedFlags: map[string]struct{}{ multiValuedFlags := map[string]bool{
"override_tensor": {}, "override_tensor": true,
"override_kv": {}, "override_kv": true,
"lora": {}, "lora": true,
"lora_scaled": {}, "lora_scaled": true,
"control_vector": {}, "control_vector": true,
"control_vector_scaled": {}, "control_vector_scaled": true,
"dry_sequence_breaker": {}, "dry_sequence_breaker": true,
"logit_bias": {}, "logit_bias": true,
},
} }
var llamaOptions LlamaServerOptions var llamaOptions LlamaServerOptions
if err := backends.ParseCommand(command, config, &llamaOptions); err != nil { if err := backends.ParseCommand(command, executableNames, subcommandNames, multiValuedFlags, &llamaOptions); err != nil {
return nil, err return nil, err
} }

View File

@@ -106,10 +106,8 @@ func (o *MlxServerOptions) UnmarshalJSON(data []byte) error {
return nil return nil
} }
// BuildCommandArgs converts to command line arguments using the common builder // BuildCommandArgs converts to command line arguments
func (o *MlxServerOptions) BuildCommandArgs() []string { func (o *MlxServerOptions) BuildCommandArgs() []string {
config := backends.ArgsBuilderConfig{ multipleFlags := map[string]bool{} // MLX doesn't currently have []string fields
SliceHandling: backends.SliceAsMultipleFlags, // MLX doesn't currently have []string fields, but default to multiple flags return backends.BuildCommandArgs(o, multipleFlags)
}
return backends.BuildCommandArgs(o, config)
} }

View File

@@ -11,27 +11,14 @@ import (
// 3. Args only: "--model model/path --host 0.0.0.0" // 3. Args only: "--model model/path --host 0.0.0.0"
// 4. Multiline commands with backslashes // 4. Multiline commands with backslashes
func ParseMlxCommand(command string) (*MlxServerOptions, error) { func ParseMlxCommand(command string) (*MlxServerOptions, error) {
config := backends.CommandParserConfig{ executableNames := []string{"mlx_lm.server"}
ExecutableNames: []string{"mlx_lm.server"}, var subcommandNames []string // MLX has no subcommands
MultiValuedFlags: map[string]struct{}{}, // MLX has no multi-valued flags multiValuedFlags := map[string]bool{} // MLX has no multi-valued flags
}
var mlxOptions MlxServerOptions var mlxOptions MlxServerOptions
if err := backends.ParseCommand(command, config, &mlxOptions); err != nil { if err := backends.ParseCommand(command, executableNames, subcommandNames, multiValuedFlags, &mlxOptions); err != nil {
return nil, err return nil, err
} }
return &mlxOptions, nil return &mlxOptions, nil
} }
// isValidLogLevel validates MLX log levels
func isValidLogLevel(level string) bool {
validLevels := []string{"DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"}
for _, valid := range validLevels {
if level == valid {
return true
}
}
return false
}

View File

@@ -2,7 +2,6 @@ package backends
import ( import (
"encoding/json" "encoding/json"
"errors"
"fmt" "fmt"
"path/filepath" "path/filepath"
"reflect" "reflect"
@@ -11,327 +10,41 @@ import (
"strings" "strings"
) )
// CommandParserConfig holds configuration for parsing command line arguments // ParseCommand parses a command string into a target struct
type CommandParserConfig struct { func ParseCommand(command string, executableNames []string, subcommandNames []string, multiValuedFlags map[string]bool, target any) error {
// ExecutableNames are the names of executables to detect (e.g., "llama-server", "mlx_lm.server") // Normalize multiline commands
ExecutableNames []string command = normalizeCommand(command)
// SubcommandNames are optional subcommands (e.g., "serve" for vllm) if command == "" {
SubcommandNames []string
// MultiValuedFlags are flags that can accept multiple values
MultiValuedFlags map[string]struct{}
}
// ParseCommand parses a command string using the provided configuration
func ParseCommand(command string, config CommandParserConfig, target any) error {
// 1. Normalize the command - handle multiline with backslashes
trimmed := normalizeMultilineCommand(command)
if trimmed == "" {
return fmt.Errorf("command cannot be empty") return fmt.Errorf("command cannot be empty")
} }
// 2. Extract arguments from command // Extract arguments
args, err := extractArgumentsFromCommand(trimmed, config) args, err := extractArgs(command, executableNames, subcommandNames)
if err != nil { if err != nil {
return err return err
} }
// 3. Parse arguments into map // Parse flags into map
options := make(map[string]any) options, err := parseFlags(args, multiValuedFlags)
if err != nil {
i := 0 return err
for i < len(args) {
arg := args[i]
if !strings.HasPrefix(arg, "-") { // skip positional / stray values
i++
continue
}
// Reject malformed flags with more than two leading dashes (e.g. ---model) to surface user mistakes
if strings.HasPrefix(arg, "---") {
return fmt.Errorf("malformed flag: %s", arg)
}
// Unified parsing for --flag=value vs --flag value
var rawFlag, rawValue string
hasEquals := false
if strings.Contains(arg, "=") {
parts := strings.SplitN(arg, "=", 2)
rawFlag = parts[0]
rawValue = parts[1] // may be empty string
hasEquals = true
} else {
rawFlag = arg
}
flagCore := strings.TrimPrefix(strings.TrimPrefix(rawFlag, "-"), "-")
flagName := strings.ReplaceAll(flagCore, "-", "_")
// Detect value if not in equals form
valueProvided := hasEquals
if !hasEquals {
if i+1 < len(args) && !isFlag(args[i+1]) { // next token is value
rawValue = args[i+1]
valueProvided = true
}
}
// Determine if multi-valued flag
_, isMulti := config.MultiValuedFlags[flagName]
// Normalization helper: ensure slice for multi-valued flags
appendValue := func(valStr string) {
if existing, ok := options[flagName]; ok {
// Existing value; ensure slice semantics for multi-valued flags or repeated occurrences
if slice, ok := existing.([]string); ok {
options[flagName] = append(slice, valStr)
return
}
// Convert scalar to slice
options[flagName] = []string{fmt.Sprintf("%v", existing), valStr}
return
}
// First value
if isMulti {
options[flagName] = []string{valStr}
} else {
// We'll parse type below for single-valued flags
options[flagName] = valStr
}
}
if valueProvided {
// Use raw token for multi-valued flags; else allow typed parsing
appendValue(rawValue)
if !isMulti { // convert to typed value if scalar
if strVal, ok := options[flagName].(string); ok { // still scalar
options[flagName] = parseValue(strVal)
}
}
// Advance index: if we consumed a following token as value (non equals form), skip it
if !hasEquals && i+1 < len(args) && rawValue == args[i+1] {
i += 2
} else {
i++
}
continue
}
// Boolean flag (no value)
options[flagName] = true
i++
} }
// 4. Convert to target struct using JSON marshaling // Convert to target struct via JSON
jsonData, err := json.Marshal(options) jsonData, err := json.Marshal(options)
if err != nil { if err != nil {
return fmt.Errorf("failed to marshal parsed options: %w", err) return fmt.Errorf("failed to marshal options: %w", err)
} }
if err := json.Unmarshal(jsonData, target); err != nil { if err := json.Unmarshal(jsonData, target); err != nil {
return fmt.Errorf("failed to parse command options: %w", err) return fmt.Errorf("failed to unmarshal to target: %w", err)
} }
return nil return nil
} }
// parseValue attempts to parse a string value into the most appropriate type // BuildCommandArgs converts a struct to command line arguments
func parseValue(value string) any { func BuildCommandArgs(options any, multipleFlags map[string]bool) []string {
// Surrounding matching quotes (single or double)
if l := len(value); l >= 2 {
if (value[0] == '"' && value[l-1] == '"') || (value[0] == '\'' && value[l-1] == '\'') {
value = value[1 : l-1]
}
}
lower := strings.ToLower(value)
if lower == "true" {
return true
}
if lower == "false" {
return false
}
if intVal, err := strconv.Atoi(value); err == nil {
return intVal
}
if floatVal, err := strconv.ParseFloat(value, 64); err == nil {
return floatVal
}
return value
}
// normalizeMultilineCommand handles multiline commands with backslashes
func normalizeMultilineCommand(command string) string {
// Handle escaped newlines (backslash followed by newline)
re := regexp.MustCompile(`\\\s*\n\s*`)
normalized := re.ReplaceAllString(command, " ")
// Clean up extra whitespace
re = regexp.MustCompile(`\s+`)
normalized = re.ReplaceAllString(normalized, " ")
return strings.TrimSpace(normalized)
}
// extractArgumentsFromCommand extracts arguments from various command formats
func extractArgumentsFromCommand(command string, config CommandParserConfig) ([]string, error) {
// Split command into tokens respecting quotes
tokens, err := splitCommandTokens(command)
if err != nil {
return nil, err
}
if len(tokens) == 0 {
return nil, fmt.Errorf("no command tokens found")
}
firstToken := tokens[0]
// Check for full path executable
if strings.Contains(firstToken, string(filepath.Separator)) {
baseName := filepath.Base(firstToken)
for _, execName := range config.ExecutableNames {
if strings.HasSuffix(baseName, execName) {
return skipExecutableAndSubcommands(tokens[1:], config.SubcommandNames)
}
}
// Unknown executable, assume it's still an executable
return skipExecutableAndSubcommands(tokens[1:], config.SubcommandNames)
}
// Check for simple executable names
lowerFirstToken := strings.ToLower(firstToken)
for _, execName := range config.ExecutableNames {
if lowerFirstToken == strings.ToLower(execName) {
return skipExecutableAndSubcommands(tokens[1:], config.SubcommandNames)
}
}
// Check for subcommands (like "serve" for vllm)
for _, subCmd := range config.SubcommandNames {
if lowerFirstToken == strings.ToLower(subCmd) {
return tokens[1:], nil // Return everything except the subcommand
}
}
// Arguments only (starts with a flag)
if strings.HasPrefix(firstToken, "-") {
return tokens, nil // Return all tokens as arguments
}
// Unknown format - might be a different executable name
return skipExecutableAndSubcommands(tokens[1:], config.SubcommandNames)
}
// skipExecutableAndSubcommands removes subcommands from the beginning of tokens
func skipExecutableAndSubcommands(tokens []string, subcommands []string) ([]string, error) {
if len(tokens) == 0 {
return tokens, nil
}
// Check if first token is a subcommand
if len(subcommands) > 0 && len(tokens) > 0 {
lowerFirstToken := strings.ToLower(tokens[0])
for _, subCmd := range subcommands {
if lowerFirstToken == strings.ToLower(subCmd) {
return tokens[1:], nil // Skip the subcommand
}
}
}
return tokens, nil
}
// splitCommandTokens splits a command string into tokens, respecting quotes
func splitCommandTokens(command string) ([]string, error) {
var tokens []string
var current strings.Builder
inQuotes := false
quoteChar := byte(0)
escaped := false
for i := 0; i < len(command); i++ {
c := command[i]
if escaped {
current.WriteByte(c)
escaped = false
continue
}
if c == '\\' {
escaped = true
current.WriteByte(c)
continue
}
if !inQuotes && (c == '"' || c == '\'') {
inQuotes = true
quoteChar = c
current.WriteByte(c)
} else if inQuotes && c == quoteChar {
inQuotes = false
quoteChar = 0
current.WriteByte(c)
} else if !inQuotes && (c == ' ' || c == '\t' || c == '\n') {
if current.Len() > 0 {
tokens = append(tokens, current.String())
current.Reset()
}
} else {
current.WriteByte(c)
}
}
if inQuotes {
return nil, errors.New("unterminated quoted string")
}
if current.Len() > 0 {
tokens = append(tokens, current.String())
}
return tokens, nil
}
// isFlag determines if a string is a command line flag or a value
// Handles the special case where negative numbers should be treated as values, not flags
func isFlag(arg string) bool {
if !strings.HasPrefix(arg, "-") {
return false
}
// Special case: if it's a negative number, treat it as a value
if _, err := strconv.ParseFloat(arg, 64); err == nil {
return false
}
return true
}
// SliceHandling defines how []string fields should be handled when building command args
type SliceHandling int
const (
// SliceAsMultipleFlags creates multiple flags: --flag value1 --flag value2
SliceAsMultipleFlags SliceHandling = iota
// SliceAsCommaSeparated creates single flag with comma-separated values: --flag value1,value2
SliceAsCommaSeparated
// SliceAsMixed uses different strategies for different flags (requires configuration)
SliceAsMixed
)
// ArgsBuilderConfig holds configuration for building command line arguments
type ArgsBuilderConfig struct {
// SliceHandling defines the default strategy for []string fields
SliceHandling SliceHandling
// MultipleFlags specifies which flags should use multiple instances when SliceHandling is SliceAsMixed
MultipleFlags map[string]struct{}
}
// BuildCommandArgs converts a struct to command line arguments using reflection
func BuildCommandArgs(options any, config ArgsBuilderConfig) []string {
var args []string var args []string
v := reflect.ValueOf(options).Elem() v := reflect.ValueOf(options).Elem()
@@ -341,27 +54,19 @@ func BuildCommandArgs(options any, config ArgsBuilderConfig) []string {
field := v.Field(i) field := v.Field(i)
fieldType := t.Field(i) fieldType := t.Field(i)
// Skip unexported fields
if !field.CanInterface() { if !field.CanInterface() {
continue continue
} }
// Get the JSON tag to determine the flag name
jsonTag := fieldType.Tag.Get("json") jsonTag := fieldType.Tag.Get("json")
if jsonTag == "" || jsonTag == "-" { if jsonTag == "" || jsonTag == "-" {
continue continue
} }
// Remove ",omitempty" from the tag // Get flag name from JSON tag
flagName := jsonTag flagName := strings.Split(jsonTag, ",")[0]
if commaIndex := strings.Index(jsonTag, ","); commaIndex != -1 {
flagName = jsonTag[:commaIndex]
}
// Convert snake_case to kebab-case for CLI flags
flagName = strings.ReplaceAll(flagName, "_", "-") flagName = strings.ReplaceAll(flagName, "_", "-")
// Add the appropriate arguments based on field type and value
switch field.Kind() { switch field.Kind() {
case reflect.Bool: case reflect.Bool:
if field.Bool() { if field.Bool() {
@@ -380,8 +85,20 @@ func BuildCommandArgs(options any, config ArgsBuilderConfig) []string {
args = append(args, "--"+flagName, field.String()) args = append(args, "--"+flagName, field.String())
} }
case reflect.Slice: case reflect.Slice:
if field.Type().Elem().Kind() == reflect.String { if field.Type().Elem().Kind() == reflect.String && field.Len() > 0 {
args = append(args, handleStringSlice(field, flagName, config)...) if multipleFlags[flagName] {
// Multiple flags: --flag value1 --flag value2
for j := 0; j < field.Len(); j++ {
args = append(args, "--"+flagName, field.Index(j).String())
}
} else {
// Comma-separated: --flag value1,value2
var values []string
for j := 0; j < field.Len(); j++ {
values = append(values, field.Index(j).String())
}
args = append(args, "--"+flagName, strings.Join(values, ","))
}
} }
} }
} }
@@ -389,43 +106,155 @@ func BuildCommandArgs(options any, config ArgsBuilderConfig) []string {
return args return args
} }
// handleStringSlice handles []string fields based on the configuration // normalizeCommand handles multiline commands with backslashes
func handleStringSlice(field reflect.Value, flagName string, config ArgsBuilderConfig) []string { func normalizeCommand(command string) string {
if field.Len() == 0 { re := regexp.MustCompile(`\\\s*\n\s*`)
return nil normalized := re.ReplaceAllString(command, " ")
re = regexp.MustCompile(`\s+`)
return strings.TrimSpace(re.ReplaceAllString(normalized, " "))
}
// extractArgs extracts arguments from command, removing executable and subcommands
func extractArgs(command string, executableNames []string, subcommandNames []string) ([]string, error) {
// Check for unterminated quotes
if strings.Count(command, `"`)%2 != 0 || strings.Count(command, `'`)%2 != 0 {
return nil, fmt.Errorf("unterminated quoted string")
} }
var args []string tokens := strings.Fields(command)
if len(tokens) == 0 {
return nil, fmt.Errorf("no tokens found")
}
switch config.SliceHandling { // Skip executable
case SliceAsMultipleFlags: start := 0
// Multiple flags: --flag value1 --flag value2 firstToken := tokens[0]
for j := 0; j < field.Len(); j++ {
args = append(args, "--"+flagName, field.Index(j).String()) // Check for executable name (with or without path)
if strings.Contains(firstToken, string(filepath.Separator)) {
baseName := filepath.Base(firstToken)
for _, execName := range executableNames {
if strings.HasSuffix(strings.ToLower(baseName), strings.ToLower(execName)) {
start = 1
break
}
} }
case SliceAsCommaSeparated: } else {
// Comma-separated: --flag value1,value2 for _, execName := range executableNames {
var values []string if strings.EqualFold(firstToken, execName) {
for j := 0; j < field.Len(); j++ { start = 1
values = append(values, field.Index(j).String()) break
}
} }
args = append(args, "--"+flagName, strings.Join(values, ",")) }
case SliceAsMixed:
// Check if this specific flag should use multiple instances // Skip subcommand if present
if _, useMultiple := config.MultipleFlags[flagName]; useMultiple { if start < len(tokens) {
// Multiple flags for _, subCmd := range subcommandNames {
for j := 0; j < field.Len(); j++ { if strings.EqualFold(tokens[start], subCmd) {
args = append(args, "--"+flagName, field.Index(j).String()) start++
break
}
}
}
// Handle case where command starts with subcommand (no executable)
if start == 0 {
for _, subCmd := range subcommandNames {
if strings.EqualFold(firstToken, subCmd) {
start = 1
break
}
}
}
return tokens[start:], nil
}
// parseFlags parses command line flags into a map
func parseFlags(args []string, multiValuedFlags map[string]bool) (map[string]any, error) {
options := make(map[string]any)
for i := 0; i < len(args); i++ {
arg := args[i]
if !strings.HasPrefix(arg, "-") {
continue
}
// Check for malformed flags (more than two leading dashes)
if strings.HasPrefix(arg, "---") {
return nil, fmt.Errorf("malformed flag: %s", arg)
}
// Get flag name and value
var flagName, value string
var hasValue bool
if strings.Contains(arg, "=") {
parts := strings.SplitN(arg, "=", 2)
flagName = strings.TrimLeft(parts[0], "-")
value = parts[1]
hasValue = true
} else {
flagName = strings.TrimLeft(arg, "-")
if i+1 < len(args) && !strings.HasPrefix(args[i+1], "-") {
value = args[i+1]
hasValue = true
i++ // Skip next arg since we consumed it
}
}
// Convert kebab-case to snake_case for JSON
flagName = strings.ReplaceAll(flagName, "-", "_")
if hasValue {
// Handle multi-valued flags
if multiValuedFlags[flagName] {
if existing, ok := options[flagName].([]string); ok {
options[flagName] = append(existing, value)
} else {
options[flagName] = []string{value}
}
} else {
options[flagName] = parseValue(value)
} }
} else { } else {
// Comma-separated // Boolean flag
var values []string options[flagName] = true
for j := 0; j < field.Len(); j++ {
values = append(values, field.Index(j).String())
}
args = append(args, "--"+flagName, strings.Join(values, ","))
} }
} }
return args return options, nil
}
// parseValue converts string to appropriate type
func parseValue(value string) any {
// Remove quotes
if len(value) >= 2 {
if (value[0] == '"' && value[len(value)-1] == '"') || (value[0] == '\'' && value[len(value)-1] == '\'') {
value = value[1 : len(value)-1]
}
}
// Try boolean
switch strings.ToLower(value) {
case "true":
return true
case "false":
return false
}
// Try integer
if intVal, err := strconv.Atoi(value); err == nil {
return intVal
}
// Try float
if floatVal, err := strconv.ParseFloat(value, 64); err == nil {
return floatVal
}
// Return as string
return value
} }

View File

@@ -12,22 +12,20 @@ import (
// 4. Args only: "--model MODEL_NAME --other-args" // 4. Args only: "--model MODEL_NAME --other-args"
// 5. Multiline commands with backslashes // 5. Multiline commands with backslashes
func ParseVllmCommand(command string) (*VllmServerOptions, error) { func ParseVllmCommand(command string) (*VllmServerOptions, error) {
config := backends.CommandParserConfig{ executableNames := []string{"vllm"}
ExecutableNames: []string{"vllm"}, subcommandNames := []string{"serve"}
SubcommandNames: []string{"serve"}, multiValuedFlags := map[string]bool{
MultiValuedFlags: map[string]struct{}{ "middleware": true,
"middleware": {}, "api_key": true,
"api_key": {}, "allowed_origins": true,
"allowed_origins": {}, "allowed_methods": true,
"allowed_methods": {}, "allowed_headers": true,
"allowed_headers": {}, "lora_modules": true,
"lora_modules": {}, "prompt_adapters": true,
"prompt_adapters": {},
},
} }
var vllmOptions VllmServerOptions var vllmOptions VllmServerOptions
if err := backends.ParseCommand(command, config, &vllmOptions); err != nil { if err := backends.ParseCommand(command, executableNames, subcommandNames, multiValuedFlags, &vllmOptions); err != nil {
return nil, err return nil, err
} }

View File

@@ -130,18 +130,15 @@ type VllmServerOptions struct {
OverrideKVCacheALIGNSize int `json:"override_kv_cache_align_size,omitempty"` OverrideKVCacheALIGNSize int `json:"override_kv_cache_align_size,omitempty"`
} }
// BuildCommandArgs converts VllmServerOptions to command line arguments using the common builder // BuildCommandArgs converts VllmServerOptions to command line arguments
// Note: This does NOT include the "serve" subcommand, that's handled at the instance level // Note: This does NOT include the "serve" subcommand, that's handled at the instance level
func (o *VllmServerOptions) BuildCommandArgs() []string { func (o *VllmServerOptions) BuildCommandArgs() []string {
config := backends.ArgsBuilderConfig{ multipleFlags := map[string]bool{
SliceHandling: backends.SliceAsMixed, "api-key": true,
MultipleFlags: map[string]struct{}{ "allowed-origins": true,
"api-key": {}, "allowed-methods": true,
"allowed-origins": {}, "allowed-headers": true,
"allowed-methods": {}, "middleware": true,
"allowed-headers": {},
"middleware": {},
},
} }
return backends.BuildCommandArgs(o, config) return backends.BuildCommandArgs(o, multipleFlags)
} }