Mathis/lemma
1
0
Fork 0
mirror of https://github.com/lordmathis/lemma.git synced 2025-11-06 07:54:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor modal tests for improved clarity and consistency in content and actions

Browse Source
This commit is contained in:
Matúš Námešný
2025-06-29 16:06:35 +02:00
parent 8d9222d084
commit 32d03347fc
12 changed files with 122 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
app/src/components/modals/account/DeleteAccountModal.test.tsx
View File

@@ -28,8 +28,8 @@ describe('DeleteAccountModal', () => {
mockOnConfirm.mockResolvedValue(undefined);
});
describe('Modal Visibility', () => {
it('shows modal with warning and form when opened', () => {
describe('Modal Visibility and Content', () => {
it('renders modal with correct content when opened', () => {
render(
<DeleteAccountModal
opened={true}
@@ -50,11 +50,15 @@ describe('DeleteAccountModal', () => {
expect(
screen.getByTestId('delete-account-password-input')
).toBeInTheDocument();
expect(screen.getByTestId('cancel-delete-button')).toBeInTheDocument();
expect(screen.getByTestId('confirm-delete-button')).toBeInTheDocument();
expect(
screen.getByTestId('cancel-delete-account-button')
).toBeInTheDocument();
expect(
screen.getByTestId('confirm-delete-account-button')
).toBeInTheDocument();
});
it('hides modal when closed', () => {
it('does not render when closed', () => {
render(
<DeleteAccountModal
opened={false}
@@ -67,7 +71,7 @@ describe('DeleteAccountModal', () => {
});
});
describe('Password Input and Validation', () => {
describe('Form Validation', () => {
it('updates password value when user types', () => {
render(
<DeleteAccountModal
@@ -93,7 +97,7 @@ describe('DeleteAccountModal', () => {
);
const passwordInput = screen.getByTestId('delete-account-password-input');
const deleteButton = screen.getByTestId('confirm-delete-button');
const deleteButton = screen.getByTestId('confirm-delete-account-button');
// Test empty password
fireEvent.click(deleteButton);
@@ -104,8 +108,10 @@ describe('DeleteAccountModal', () => {
fireEvent.click(deleteButton);
expect(mockOnConfirm).not.toHaveBeenCalled();
});
});
it('submits with valid password and clears field on success', async () => {
describe('User Actions', () => {
it('calls onConfirm with valid password and clears field on success', async () => {
render(
<DeleteAccountModal
opened={true}
@@ -115,7 +121,7 @@ describe('DeleteAccountModal', () => {
);
const passwordInput = screen.getByTestId('delete-account-password-input');
const deleteButton = screen.getByTestId('confirm-delete-button');
const deleteButton = screen.getByTestId('confirm-delete-account-button');
fireEvent.change(passwordInput, { target: { value: 'validpassword' } });
fireEvent.click(deleteButton);
@@ -129,6 +135,20 @@ describe('DeleteAccountModal', () => {
});
});
it('calls onClose when cancel button is clicked', () => {
render(
<DeleteAccountModal
opened={true}
onClose={mockOnClose}
onConfirm={mockOnConfirm}
/>
);
fireEvent.click(screen.getByTestId('cancel-delete-account-button'));
expect(mockOnClose).toHaveBeenCalled();
expect(mockOnConfirm).not.toHaveBeenCalled();
});
it('preserves password in field when submission fails', async () => {
mockOnConfirm.mockRejectedValue(new Error('Invalid password'));
@@ -141,7 +161,7 @@ describe('DeleteAccountModal', () => {
);
const passwordInput = screen.getByTestId('delete-account-password-input');
const deleteButton = screen.getByTestId('confirm-delete-button');
const deleteButton = screen.getByTestId('confirm-delete-account-button');
fireEvent.change(passwordInput, { target: { value: 'wrongpassword' } });
fireEvent.click(deleteButton);
@@ -165,7 +185,7 @@ describe('DeleteAccountModal', () => {
/>
);
const cancelButton = screen.getByTestId('cancel-delete-button');
const cancelButton = screen.getByTestId('cancel-delete-account-button');
fireEvent.click(cancelButton);
expect(mockOnClose).toHaveBeenCalled();
@@ -182,7 +202,7 @@ describe('DeleteAccountModal', () => {
);
const passwordInput = screen.getByTestId('delete-account-password-input');
const deleteButton = screen.getByTestId('confirm-delete-button');
const deleteButton = screen.getByTestId('confirm-delete-account-button');
fireEvent.change(passwordInput, { target: { value: 'testpassword' } });
@@ -240,7 +260,7 @@ describe('DeleteAccountModal', () => {
fireEvent.change(passwordInput, { target: { value: 'userpassword' } });
// 3. User confirms deletion
const deleteButton = screen.getByTestId('confirm-delete-button');
const deleteButton = screen.getByTestId('confirm-delete-account-button');
fireEvent.click(deleteButton);
// 4. System processes deletion
@@ -267,7 +287,7 @@ describe('DeleteAccountModal', () => {
const passwordInput = screen.getByTestId('delete-account-password-input');
fireEvent.change(passwordInput, { target: { value: 'somepassword' } });
const cancelButton = screen.getByTestId('cancel-delete-button');
const cancelButton = screen.getByTestId('cancel-delete-account-button');
fireEvent.click(cancelButton);
// Modal closes without deletion