package manager_test import ( "llamactl/pkg/backends" "llamactl/pkg/config" "llamactl/pkg/instance" "llamactl/pkg/manager" "strings" "testing" ) func TestCreateInstance_FailsWithDuplicateName(t *testing.T) { mngr := createTestManager() options := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", }, }, } _, err := mngr.CreateInstance("test-instance", options) if err != nil { t.Fatalf("First CreateInstance failed: %v", err) } // Try to create duplicate _, err = mngr.CreateInstance("test-instance", options) if err == nil { t.Error("Expected error for duplicate instance name") } if !strings.Contains(err.Error(), "already exists") { t.Errorf("Expected duplicate name error, got: %v", err) } } func TestCreateInstance_FailsWhenMaxInstancesReached(t *testing.T) { appConfig := &config.AppConfig{ Backends: config.BackendConfig{ LlamaCpp: config.BackendSettings{ Command: "llama-server", }, }, Instances: config.InstancesConfig{ PortRange: [2]int{8000, 9000}, MaxInstances: 1, // Very low limit for testing TimeoutCheckInterval: 5, }, LocalNode: "main", Nodes: map[string]config.NodeConfig{}, } limitedManager := manager.New(appConfig) options := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", }, }, } _, err := limitedManager.CreateInstance("instance1", options) if err != nil { t.Fatalf("CreateInstance 1 failed: %v", err) } // This should fail due to max instances limit _, err = limitedManager.CreateInstance("instance2", options) if err == nil { t.Error("Expected error when exceeding max instances limit") } if !strings.Contains(err.Error(), "maximum number of instances") { t.Errorf("Expected max instances error, got: %v", err) } } func TestCreateInstance_FailsWithPortConflict(t *testing.T) { manager := createTestManager() options1 := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", Port: 8080, }, }, } _, err := manager.CreateInstance("instance1", options1) if err != nil { t.Fatalf("CreateInstance failed: %v", err) } // Try to create instance with same port options2 := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model2.gguf", Port: 8080, // Same port - should conflict }, }, } _, err = manager.CreateInstance("instance2", options2) if err == nil { t.Error("Expected error for port conflict") } if !strings.Contains(err.Error(), "port") && !strings.Contains(err.Error(), "in use") { t.Errorf("Expected port conflict error, got: %v", err) } } func TestInstanceOperations_FailWithNonExistentInstance(t *testing.T) { manager := createTestManager() options := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", }, }, } _, err := manager.GetInstance("nonexistent") if err == nil || !strings.Contains(err.Error(), "not found") { t.Errorf("Expected 'not found' error, got: %v", err) } err = manager.DeleteInstance("nonexistent") if err == nil || !strings.Contains(err.Error(), "not found") { t.Errorf("Expected 'not found' error, got: %v", err) } _, err = manager.UpdateInstance("nonexistent", options) if err == nil || !strings.Contains(err.Error(), "not found") { t.Errorf("Expected 'not found' error, got: %v", err) } } func TestDeleteInstance_RunningInstanceFails(t *testing.T) { mgr := createTestManager() defer mgr.Shutdown() options := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", }, }, } inst, err := mgr.CreateInstance("test-instance", options) if err != nil { t.Fatalf("CreateInstance failed: %v", err) } // Simulate starting the instance inst.SetStatus(instance.Running) // Should fail to delete running instance err = mgr.DeleteInstance("test-instance") if err == nil { t.Error("Expected error when deleting running instance") } } func TestUpdateInstance(t *testing.T) { mgr := createTestManager() defer mgr.Shutdown() options := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", Port: 8080, }, }, } inst, err := mgr.CreateInstance("test-instance", options) if err != nil { t.Fatalf("CreateInstance failed: %v", err) } // Simulate starting the instance inst.SetStatus(instance.Running) // Update running instance with new model newOptions := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/new-model.gguf", Port: 8080, }, }, } updated, err := mgr.UpdateInstance("test-instance", newOptions) if err != nil { t.Fatalf("UpdateInstance failed: %v", err) } // Should be either running or restarting after update status := updated.GetStatus() if status != instance.Running && status != instance.Restarting { t.Error("Instance should be running or restarting after update") } if updated.GetOptions().BackendOptions.LlamaServerOptions.Model != "/path/to/new-model.gguf" { t.Errorf("Expected model to be updated") } } func TestUpdateInstance_ReleasesOldPort(t *testing.T) { mgr := createTestManager() defer mgr.Shutdown() options := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", Port: 8080, }, }, } inst, err := mgr.CreateInstance("test-instance", options) if err != nil { t.Fatalf("CreateInstance failed: %v", err) } if inst.GetPort() != 8080 { t.Errorf("Expected port 8080, got %d", inst.GetPort()) } // Update with new port newOptions := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model.gguf", Port: 8081, }, }, } updated, err := mgr.UpdateInstance("test-instance", newOptions) if err != nil { t.Fatalf("UpdateInstance failed: %v", err) } if updated.GetPort() != 8081 { t.Errorf("Expected port 8081, got %d", updated.GetPort()) } // Old port should be released - try to create new instance with old port options2 := &instance.Options{ BackendOptions: backends.Options{ BackendType: backends.BackendTypeLlamaCpp, LlamaServerOptions: &backends.LlamaServerOptions{ Model: "/path/to/model2.gguf", Port: 8080, }, }, } _, err = mgr.CreateInstance("test-instance-2", options2) if err != nil { t.Errorf("Should be able to use old port 8080: %v", err) } }